[libvirt PATCH v5 26/32] qemu: try to connect to nbdkit early to detect errors
Jonathon Jongsma
jjongsma at redhat.com
Tue Feb 14 17:08:13 UTC 2023
When using nbdkit to serve a network disk source, the nbdkit process
will start and wait for an nbd connection before actually attempting to
connect to the (remote) disk location. Because of this, nbdkit will not
report an error until after qemu is launched and tries to read from the
disk. This results in a fairly user-unfriendly error saying that qemu
was unable to start because "Requested export not available".
Ideally we'd like to be able to tell the user *why* the export is not
available, but this sort of information is only available to nbdkit, not
qemu. It could be because the url was incorrect, or because of an
authentication failure, or one of many other possibilities.
To make this friendlier for users and easier to detect
misconfigurations, try to connect to nbdkit immediately after starting
nbdkit and before we try to start qemu. This requires adding a
dependency on libnbd. If an error occurs when connecting to nbdkit, read
back from the nbdkit error log and provide that information in the error
report from qemuNbdkitProcessStart().
User-visible change demonstrated below:
Previous error:
$ virsh start nbdkit-test
2023-01-18 19:47:45.778+0000: 30895: error : virNetClientProgramDispatchError:172 : internal
error: process exited while connecting to monitor: 2023-01-18T19:47:45.704658Z
qemu-system-x86_64: -blockdev {"driver":"nbd","server":{"type":"unix",
"path":"/var/lib/libvirt/qemu/domain-1-nbdkit-test/nbdkit-libvirt-1-storage.socket"},
"node-name":"libvirt-1-storage","auto-read-only":true,"discard":"unmap"}: Requested export not
available
error: Failed to start domain 'nbdkit-test'
error: internal error: process exited while connecting to monitor: 2023-01-18T19:47:45.704658Z
qemu-system-x86_64: -blockdev {"driver":"nbd","server":{"type":"unix",
"path":"/var/lib/libvirt/qemu/domain-1-nbdkit-test/nbdkit-libvirt-1-storage.socket"},
"node-name":"libvirt-1-storage","auto-read-only":true,"discard":"unmap"}: Requested export not
available
After this change:
$ virsh start nbdkit-test
2023-01-18 19:44:36.242+0000: 30895: error : virNetClientProgramDispatchError:172 : internal
error: Failed to connect to nbdkit for 'http://localhost:8888/nonexistent.iso': nbdkit: curl[1]:
error: problem doing HEAD request to fetch size of URL [http://localhost:8888/nonexistent.iso]:
HTTP response code said error: The requested URL returned error: 404
error: Failed to start domain 'nbdkit-test'
error: internal error: Failed to connect to nbdkit for 'http://localhost:8888/nonexistent.iso]:
error: problem doing HEAD request to fetch size of URL [http://localhost:8888/nonexistent.iso]:
HTTP response code said error: The requested URL returned error: 404
Signed-off-by: Jonathon Jongsma <jjongsma at redhat.com>
---
meson.build | 7 +++++++
meson_options.txt | 1 +
src/qemu/meson.build | 1 +
src/qemu/qemu_nbdkit.c | 24 ++++++++++++++++++++++++
4 files changed, 33 insertions(+)
diff --git a/meson.build b/meson.build
index 048b15ff71..83692bef22 100644
--- a/meson.build
+++ b/meson.build
@@ -959,6 +959,12 @@ endif
libiscsi_version = '1.18.0'
libiscsi_dep = dependency('libiscsi', version: '>=' + libiscsi_version, required: get_option('libiscsi'))
+libnbd_version = '1.0'
+libnbd_dep = dependency('libnbd', version: '>=' + libnbd_version, required: get_option('libnbd'))
+if libnbd_dep.found()
+ conf.set('WITH_LIBNBD', 1)
+endif
+
libnl_version = '3.0'
if not get_option('libnl').disabled() and host_machine.system() == 'linux'
libnl_dep = dependency('libnl-3.0', version: '>=' + libnl_version, required: get_option('libnl'))
@@ -2200,6 +2206,7 @@ libs_summary = {
'glusterfs': glusterfs_dep.found(),
'libiscsi': libiscsi_dep.found(),
'libkvm': libkvm_dep.found(),
+ 'libnbd': libnbd_dep.found(),
'libnl': libnl_dep.found(),
'libparted': libparted_dep.found(),
'libpcap': libpcap_dep.found(),
diff --git a/meson_options.txt b/meson_options.txt
index 861c5577d2..2d68bd7349 100644
--- a/meson_options.txt
+++ b/meson_options.txt
@@ -24,6 +24,7 @@ option('curl', type: 'feature', value: 'auto', description: 'curl support')
option('fuse', type: 'feature', value: 'auto', description: 'fuse support')
option('glusterfs', type: 'feature', value: 'auto', description: 'glusterfs support')
option('libiscsi', type: 'feature', value: 'auto', description: 'libiscsi support')
+option('libnbd', type: 'feature', value: 'auto', description: 'libnbd support')
option('libnl', type: 'feature', value: 'auto', description: 'libnl support')
option('libpcap', type: 'feature', value: 'auto', description: 'libpcap support')
option('libssh', type: 'feature', value: 'auto', description: 'libssh support')
diff --git a/src/qemu/meson.build b/src/qemu/meson.build
index 6d7a1bfbb0..607b597c8c 100644
--- a/src/qemu/meson.build
+++ b/src/qemu/meson.build
@@ -99,6 +99,7 @@ if conf.has('WITH_QEMU')
access_dep,
capng_dep,
gnutls_dep,
+ libnbd_dep,
libnl_dep,
log_dep,
selinux_dep,
diff --git a/src/qemu/qemu_nbdkit.c b/src/qemu/qemu_nbdkit.c
index 74e2ceee19..b2527eff2d 100644
--- a/src/qemu/qemu_nbdkit.c
+++ b/src/qemu/qemu_nbdkit.c
@@ -19,6 +19,9 @@
#include <config.h>
#include <glib.h>
+#if WITH_LIBNBD
+# include <libnbd.h>
+#endif
#include <sys/syscall.h>
#include "vircommand.h"
@@ -27,6 +30,7 @@
#include "virlog.h"
#include "virpidfile.h"
#include "virsecureerase.h"
+#include "virstring.h"
#include "virtime.h"
#include "virutil.h"
#include "qemu_block.h"
@@ -1157,6 +1161,9 @@ qemuNbdkitProcessStart(qemuNbdkitProcess *proc,
g_autofree char *errmsg = NULL;
g_autoptr(virURI) uri = NULL;
g_autofree char *uristring = NULL;
+#if WITH_LIBNBD
+ struct nbd_handle *nbd = NULL;
+#endif
if (!(cmd = qemuNbdkitProcessBuildCommand(proc)))
return -1;
@@ -1211,6 +1218,23 @@ qemuNbdkitProcessStart(qemuNbdkitProcess *proc,
goto error;
}
+#if WITH_LIBNBD
+ /* if the disk source was misconfigured, nbdkit will not produce an error
+ * until somebody connects to the socket and tries to access the nbd
+ * export. This results in poor user experience because the only error we
+ * would get from qemu is something like "Requested export not available".
+ * So let's try to access it ourselves so that we can error out early and
+ * provide a useful message to the user.
+ */
+ nbd = nbd_create();
+ if (nbd_connect_unix(nbd, proc->socketfile) < 0) {
+ VIR_WARN("nbd_connect_unix failed: %s", nbd_get_error());
+ nbd_close(nbd);
+ goto error;
+ }
+ nbd_close(nbd);
+#endif
+
if (qemuNbdkitProcessStartMonitor(proc, vm) < 0)
goto error;
--
2.39.1
More information about the libvir-list
mailing list