[libvirt PATCH 15/33] qemu: Clear os.firmwareFeatures after autoselection

Andrea Bolognani abologna at redhat.com
Wed Feb 15 10:42:12 UTC 2023


We already clear os.firmware, so it doesn't make sense to keep
the list of features around.

Moreover, our validation routines will reject an XML that
contains a list of firmware features but disables firmware
autoselection, so not clearing these means that the live XML
for a domain that uses feature-based autoselection can't be
fed back into libvirt.

Signed-off-by: Andrea Bolognani <abologna at redhat.com>
---
 src/qemu/qemu_firmware.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/qemu/qemu_firmware.c b/src/qemu/qemu_firmware.c
index 175a4db21d..572172bc75 100644
--- a/src/qemu/qemu_firmware.c
+++ b/src/qemu/qemu_firmware.c
@@ -1454,6 +1454,7 @@ qemuFirmwareFillDomain(virQEMUDriver *driver,
         goto cleanup;
 
     def->os.firmware = VIR_DOMAIN_OS_DEF_FIRMWARE_NONE;
+    VIR_FREE(def->os.firmwareFeatures);
 
     ret = 0;
  cleanup:
-- 
2.39.1



More information about the libvir-list mailing list