[libvirt PATCH 2/2] syntax-check: Ensure Python is called via env(1)

Andrea Bolognani abologna at redhat.com
Mon Feb 20 10:21:46 UTC 2023


The syntax-check rule that calls flake8 on Python scripts
expects this to be the case, and it's the best practice anyway.

Signed-off-by: Andrea Bolognani <abologna at redhat.com>
---
 build-aux/syntax-check.mk | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/build-aux/syntax-check.mk b/build-aux/syntax-check.mk
index 96d322ee04..21f6b311ce 100644
--- a/build-aux/syntax-check.mk
+++ b/build-aux/syntax-check.mk
@@ -561,6 +561,11 @@ sc_require_enum_last_marker:
 	  { echo 'enum impl needs _LAST marker on second line' 1>&2; \
 	    exit 1; } || :
 
+sc_prohibit_python_without_env:
+	@prohibit='#!/usr/.*/py''thon' \
+	 halt='always call python via /usr/bin/env' \
+	   $(_sc_search_regexp)
+
 # We're intentionally ignoring a few warnings
 #
 # E501: Force breaking lines at < 80 characters results in
-- 
2.39.2



More information about the libvir-list mailing list