[libvirt PATCH 2/2] syntax-check: Ensure Python is called via env(1)

[Erik Skultety]

On Mon, Feb 20, 2023 at 11:21:46AM +0100, Andrea Bolognani wrote:
> The syntax-check rule that calls flake8 on Python scripts
> expects this to be the case, and it's the best practice anyway.
> 
> Signed-off-by: Andrea Bolognani <abologna at redhat.com>
> ---
>  build-aux/syntax-check.mk | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/build-aux/syntax-check.mk b/build-aux/syntax-check.mk
> index 96d322ee04..21f6b311ce 100644
> --- a/build-aux/syntax-check.mk
> +++ b/build-aux/syntax-check.mk
> @@ -561,6 +561,11 @@ sc_require_enum_last_marker:
>  	  { echo 'enum impl needs _LAST marker on second line' 1>&2; \
>  	    exit 1; } || :
>  
> +sc_prohibit_python_without_env:
> +	@prohibit='#!/usr/.*/py''thon' \

Shouldn't this be just '#!/usr/.*/python' ?

Erik

> +	 halt='always call python via /usr/bin/env' \
> +	   $(_sc_search_regexp)
> +
>  # We're intentionally ignoring a few warnings
>  #
>  # E501: Force breaking lines at < 80 characters results in
> -- 
> 2.39.2
>