[PATCH 0/7] qemu: Don't use deprecated '-no-acpi' and RFC: fix ACPI config for machine types not supporting ACPI

[Daniel P. Berrangé]

On Mon, Feb 27, 2023 at 04:27:36PM +0100, Peter Krempa wrote:
> The first part of the series is a straightforward replacement of
> '-no-acpi' by '-machine acpi=on/off' based on configuration.
> 
> '-no-acpi' was recently deprecated by qemu thus we must adapt.
> 
> The second part of this series fixes the use of ACPI (or lack thereof)
> for ARM machine types which don't support ACPI. We'll break such
> commandline by adding '-no-acpi' due to historical baggage.

Which machine types are you considering here ?  Would that be
any machine type except the 'virt' machine type I guess ?

Today we just do this in the QEMU driver:

    if ((ARCH_IS_X86(guestarch) || guestarch == VIR_ARCH_AARCH64))
        virCapabilitiesAddGuestFeatureWithToggle(guest, VIR_CAPS_GUEST_FEATURE_TYPE_ACPI,
                                                 true, true);

and virt-install/virt-manager look at this to decide whether
to add <acpi/> in the domain XML.

So if we're moving this capability into domain capabilities,
to become per-machine type variable, we'll need code changes
to any apps using the historical capability.


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|