[PATCH] NEWS: note new passt feature & bugfix for 9.1.0 release

Laine Stump laine at redhat.com
Tue Feb 28 18:52:07 UTC 2023


On 2/28/23 11:11 AM, Peter Krempa wrote:
> On Tue, Feb 28, 2023 at 09:49:26 -0500, Laine Stump wrote:
>> At Stefano's suggestion, this also adds a sentence pointing out that
>> SELinux must be disabled in order for passt support to work. I didn't
>> think to put this info in the NEWS file last month.
>>
>> Signed-off-by: Laine Stump <laine at redhat.com>
>> ---
>>
>> I've noticed that in some places, QEMU related points are marked with
>> "QEMU:" and in other places they are marked with "qemu:". In the 9.1.0
>> sections, the new features all use "qemu:" while the bugfixes all use
>> "QEMU:". I just went along with the flow in both cases, but we should
>> probably do a patch to standardize on one or the other (and then try
>> to stick to it). So which is more appropriate? using the
>> capitalization the way the QEMU project prefers it? Or the
>> capitalization the way the subdirectory in libvirt is named?
> 
> [1]
> 
>>
>>   NEWS.rst | 16 ++++++++++++++++
>>   1 file changed, 16 insertions(+)
>>
>> diff --git a/NEWS.rst b/NEWS.rst
>> index 1180d75310..df613abc69 100644
>> --- a/NEWS.rst
>> +++ b/NEWS.rst
>> @@ -38,6 +38,13 @@ v9.1.0 (unreleased)
>>       A pvpanic device can be now defined as a PCI device (the original is an ISA
>>       device) with ``<panic model='pvpanic'/>``.
>>   
>> +  * qemu: support automatic restart of inadvertantly terminated passt process
>> +
> 
> Applying: NEWS: note new passt feature & bugfix for 9.1.0 release
> .git/rebase-apply/patch:23: trailing whitespace.
>    * qemu: support automatic restart of inadvertantly terminated passt process
> warning: 1 line adds whitespace errors.
> 
> Which also breaks syntax-check:
> 
> 307/315 libvirt:syntax-check / trailing_blank                                          FAIL            0.30s   exit status 2
>>>> MALLOC_PERTURB_=63 /bin/make -C /home/pipo/build/libvirt/gcc/build-aux sc_trailing_blank

Sigh. The *one* time that I think "eh, what could go wrong with a docs 
patch?" and send it without doing a build, emacs inserts a space on a 
blank line :-/

> ―――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――― ✀  ―――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――
> stdout:
> make: Entering directory '/home/pipo/build/libvirt/gcc/build-aux'
> /home/pipo/libvirt/NEWS.rst:41:  * qemu: support automatic restart of inadvertantly terminated passt process
> make: Leaving directory '/home/pipo/build/libvirt/gcc/build-aux'
> 
> 
>> +    If the passt process that is serving as the backend of a -netdev
>> +    stream is terminated unexpectedly, libvirt now listens to QEMU's
>> +    notification of this, and starts up a new passt instance, thus
>> +    preserving network connectivity.
>> +
>>   * **Improvements**
>>   
>>     * RPM packaging changes
>> @@ -63,6 +70,15 @@ v9.1.0 (unreleased)
>>       snapshot when it existed. In addition when external memory only snapshot
>>       was created libvirt failed without producing any error.
>>   
>> +  * QEMU: properly report passt startup errors
> 
> [1] you can start by standardizing inside this patch ;)

But I did! Within each section, I maintained the the consistency of that 
section.

> 
>> +
>> +    Due to how the child passt process was started, the initial
>> +    support for passt (added in 9.0.0) would not see errors
>> +    encountered during startup, so libvirt would continue to setup and
>> +    start the guest; this led to a running guest with no network
>> +    connectivity. This issue has be corrected.
> 
> Drop the last sentence. It's obvious that we've fixed it when we are
> mentioning it here.
> 
>> +
>> +    (NB: it is still necessary to disable SELinux to start passt.)
> 
> With the build error fixed and tautological sentence dropped:
> 
> Reviewed-by: Peter Krempa <pkrempa at redhat.com>
> 

Thanks!



More information about the libvir-list mailing list