[PATCH V5 10/11] spec: Remove libvirt-daemon dependency from hypervisor subpackages

Andrea Bolognani abologna at redhat.com
Mon Jan 2 15:26:13 UTC 2023


On Fri, Dec 23, 2022 at 11:56:03AM -0700, Jim Fehlig wrote:
>  %package daemon-qemu
>  Summary: Server side daemon & driver required to run QEMU guests
>
> +    %if %{with_modular_daemons}
> +Requires: libvirt-daemon-common = %{version}-%{release}
> +Requires: libvirt-daemon-log = %{version}-%{release}
> +Requires: libvirt-daemon-lock = %{version}-%{release}
> +Requires: libvirt-daemon-plugin-lockd = %{version}-%{release}
> +    %else
>  Requires: libvirt-daemon = %{version}-%{release}
> +    %endif

This version is fine, but as explained elsewhere I think it would be
better to have

    Requires: libvirt-daemon-common = %{version}-%{release}
    Requires: libvirt-daemon-log = %{version}-%{release}
    Recommends: libvirt-daemon-proxy = %{version}-%{release}

and no dependency at all on the locking part.

Rationale:

  * virtproxyd being present allows clients that are older than ~2
    years to connect, so it should be there by default while still
    making it possible for the admin to opt out, which can be done by
    simply uninstalling the corresponding package;

  * storage locking is not the default behavior and needs to be
    turned on explicitly, so it's not a big deal if part of the setup
    involves installing a couple extra packages in addition to
    editing some configuration files, and everyone else gets a leaner
    installation.

Thoughts?

-- 
Andrea Bolognani / Red Hat / Virtualization



More information about the libvir-list mailing list