[PATCH 1/7] qemu_security: Rework qemuSecurityCleanupTPMEmulator()

Peter Krempa pkrempa at redhat.com
Tue Jan 3 12:48:55 UTC 2023


On Wed, Dec 21, 2022 at 08:43:51 +0100, Michal Privoznik wrote:
> Currently, qemuSecurityCleanupTPMEmulator() returns nothing which
> means a caller (well, there's only one - qemuExtTPMStop()) can't
> produce a warning when restoring seclabels on TPM state failed.
> True, qemuSecurityCleanupTPMEmulator() does report a warning
> itself, but only in one specific error path.
> 
> Make the function return an integer, just like the rest of
> qemuSecurity*Restore() functions.
> 
> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
> ---
>  src/qemu/qemu_security.c | 21 ++++++++++++---------
>  src/qemu/qemu_security.h |  6 +++---
>  src/qemu/qemu_tpm.c      |  3 ++-
>  3 files changed, 17 insertions(+), 13 deletions(-)

Reviewed-by: Peter Krempa <pkrempa at redhat.com>


More information about the libvir-list mailing list