[PATCH] qemu_namespace: Fix detection of nested mount points
Peter Krempa
pkrempa at redhat.com
Tue Jan 3 16:33:55 UTC 2023
On Tue, Jan 03, 2023 at 17:27:27 +0100, Michal Privoznik wrote:
> When deciding whether to bind mount a path in domain's namespace,
> we look at the QEMU mount table (/proc/$pid/mounts) and try to
> match prefix of given path with one of mount points. Well, we
> do that in a bit clumsy way. For instance, if there's
> "/dev/hugepages" already mounted inside the namespace and we are
> deciding whether to bind mount "/dev/hugepages1G/..." we decide
> to skip over the path and NOT bind mount it. This is because
> plain STRPREFIX() is used and yes, the former is prefix of the
> latter. What we need to check also is whether the next character
> after the prefix is slash.
>
> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
> ---
> src/qemu/qemu_namespace.c | 4 +++-
Reviewed-by: Peter Krempa <pkrempa at redhat.com>
More information about the libvir-list
mailing list