[PATCH 17/36] virStorageSourceIsSameLocation: Use switch statement for individual storage types

Pavel Hrdina phrdina at redhat.com
Fri Jan 6 12:15:26 UTC 2023


On Thu, Jan 05, 2023 at 05:30:06PM +0100, Peter Krempa wrote:
> Convert to a switch instead of a bunch of 'if (type == ...).
> 
> Signed-off-by: Peter Krempa <pkrempa at redhat.com>
> ---
>  src/conf/storage_source_conf.c | 23 ++++++++++++++++++-----
>  1 file changed, 18 insertions(+), 5 deletions(-)
> 
> diff --git a/src/conf/storage_source_conf.c b/src/conf/storage_source_conf.c
> index 2b4cf5e241..84df8d28fa 100644
> --- a/src/conf/storage_source_conf.c
> +++ b/src/conf/storage_source_conf.c
> @@ -929,7 +929,8 @@ virStorageSourceIsSameLocation(virStorageSource *a,
>          STRNEQ_NULLABLE(a->snapshot, b->snapshot))
>          return false;
> 
> -    if (a->type == VIR_STORAGE_TYPE_NETWORK) {
> +    switch ((virStorageType) virStorageSourceGetActualType(a)) {

The typecast is probably not necessary as it already returns correct
type but it doesn't hurt as well.

Reviewed-by: Pavel Hrdina <phrdina at redhat.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20230106/5057d231/attachment-0001.sig>


More information about the libvir-list mailing list