[PATCH 25/36] conf: Add 'fdgroup' attribute for 'file' disks

[Pavel Hrdina]

On Thu, Jan 05, 2023 at 05:30:14PM +0100, Peter Krempa wrote:
> The 'fdgroup' will allow users to specify a passed FD (via the
> 'virDomainFDAssociate()' API)  use instead of opening a path. This is

/ use/to be used/ most likely or something similar as the current
sentence doesn't make sense

> useful in cases when e.g. the file is not accessible from inside a
> container.
> 
> Since this uses the same disk type as when we open files via names this
> patch also introduces a hypervisor feature which the hypervisor asserts
> that code paths are ready for this possibility.
> 
> Signed-off-by: Peter Krempa <pkrempa at redhat.com>
> ---
>  docs/formatdomain.rst                     |  8 +++++
>  src/conf/domain_conf.c                    |  2 ++
>  src/conf/domain_conf.h                    |  1 +
>  src/conf/domain_postparse.c               |  9 +++++
>  src/conf/schemas/domaincommon.rng         |  3 ++
>  src/conf/storage_source_conf.c            |  2 ++
>  src/conf/storage_source_conf.h            |  1 +
>  src/security/virt-aa-helper.c             |  3 +-
>  tests/qemuxml2argvdata/disk-source-fd.xml | 40 +++++++++++++++++++++++
>  9 files changed, 68 insertions(+), 1 deletion(-)
>  create mode 100644 tests/qemuxml2argvdata/disk-source-fd.xml

Reviewed-by: Pavel Hrdina <phrdina at redhat.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20230106/5591974a/attachment-0001.sig>