[libvirt PATCH 9/9] specfile: require passt for the build if fedora >= 36 or rhel >= 9

Ján Tomko jtomko at redhat.com
Mon Jan 9 07:32:53 UTC 2023


On a Sunday in 2023, Laine Stump wrote:
>The only reason we need it at build time is to find its location in
>$PATH so it can be hardcoded into the libvirt binary (and avoid the
>possibility of someone adding in a malicious binary somewhere earlier
>in the path, I guess).
>
>Only 'recommend' passt during installation though, since it is not
>needed unless someone is actually using it.
>
>There is no need to add in a build-time "WITH_PASST" option (IMO),
>since it adds very little to the size of the code - "PASST" (the path
>to the binary) will just be set to "passt", so if someone does manage
>to build and install passt on an older version of Fedora or RHEL, it
>will still work (as long as it's installed somewhere in the path).
>
>Signed-off-by: Laine Stump <laine at redhat.com>
>---
> libvirt.spec.in | 7 +++++++
> 1 file changed, 7 insertions(+)
>

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20230109/42cf34af/attachment.sig>


More information about the libvir-list mailing list