[PATCH 3/3] virNWFilterSaveConfig: remove the unnecessary variable 'ret'

Jiang Jiacheng jiangjiacheng at huawei.com
Mon Jan 9 11:19:31 UTC 2023


Signed-off-by: Jiang Jiacheng <jiangjiacheng at huawei.com>
---
 src/conf/nwfilter_conf.c | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/src/conf/nwfilter_conf.c b/src/conf/nwfilter_conf.c
index 382dafb13b..8d198a7bb1 100644
--- a/src/conf/nwfilter_conf.c
+++ b/src/conf/nwfilter_conf.c
@@ -2684,7 +2684,6 @@ int
 virNWFilterSaveConfig(const char *configDir,
                       virNWFilterDef *def)
 {
-    int ret = -1;
     g_autofree char *xml = NULL;
     char uuidstr[VIR_UUID_STRING_BUFLEN];
     g_autofree char *configFile = NULL;
@@ -2696,11 +2695,10 @@ virNWFilterSaveConfig(const char *configDir,
         return -1;
 
     virUUIDFormat(def->uuid, uuidstr);
-    ret = virXMLSaveFile(configFile,
-                         virXMLPickShellSafeComment(def->name, uuidstr),
-                         "nwfilter-edit", xml);
 
-    return ret;
+    return virXMLSaveFile(configFile,
+                          virXMLPickShellSafeComment(def->name, uuidstr),
+                          "nwfilter-edit", xml);
 }
 
 
-- 
2.33.0



More information about the libvir-list mailing list