[PATCH V9 07/14] spec: Add module-init-tools dependency to nodedev and lxc drivers

Jim Fehlig jfehlig at suse.com
Fri Jan 13 19:21:54 UTC 2023


Only the nodedev and lxc drivers require module-init-tools. Remove the
dependency from libvirt-daemon-common and add it to the nodedev and lxc
drivers. This avoids enforcing the dependency on all users of
libvirt-daemon-common.

Signed-off-by: Jim Fehlig <jfehlig at suse.com>
Reviewed-by: Daniel P. Berrangé <berrange at redhat.com>
Reviewed-by: Andrea Bolognani <abologna at redhat.com>
---
 libvirt.spec.in | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/libvirt.spec.in b/libvirt.spec.in
index 4c0767bbc7..5ce1099ff3 100644
--- a/libvirt.spec.in
+++ b/libvirt.spec.in
@@ -451,8 +451,6 @@ Requires: libvirt-libs = %{version}-%{release}
 # Recommends here will install libvirt-client by default (if available), but
 # RPM won't complain if the package is unavailable, masked, or removed later.
 Recommends: libvirt-client = %{version}-%{release}
-# for modprobe of pci devices
-Requires: module-init-tools
 # for /sbin/ip
 Requires: iproute
 # for /sbin/tc
@@ -574,6 +572,8 @@ Requires: libvirt-libs = %{version}-%{release}
 Requires: systemd >= 185
 # For managing persistent mediated devices
 Requires: mdevctl
+# for modprobe of pci devices
+Requires: module-init-tools
 
 %description daemon-driver-nodedev
 The nodedev driver plugin for the libvirtd daemon, providing
@@ -782,6 +782,8 @@ Requires: libvirt-libs = %{version}-%{release}
 # There really is a hard cross-driver dependency here
 Requires: libvirt-daemon-driver-network = %{version}-%{release}
 Requires: systemd-container
+# for modprobe of nbd driver
+Requires: module-init-tools
 
 %description daemon-driver-lxc
 The LXC driver plugin for the libvirtd daemon, providing
-- 
2.38.1



More information about the libvir-list mailing list