[External] : Re: [PATCH 1/1] qemuProcessEventSubmit : rename vm to event->vm

[Shaleen Bathla]

On Tue, Jan 17, 2023 at 10:09:41AM +0100, Peter Krempa wrote:
> On Tue, Jan 17, 2023 at 11:51:07 +0530, Shaleen Bathla wrote:
> > Coverity scan reports use after free issue which is a false positive.
> > In error case, free event->vm instead of vm to avoid this warning in
> > coverity.
> 
> This is an insufficient justification. We normally don't modify the code
> _only_ to silence coverity.
> 
> The reasoning is that it can be either fixed by coverity at some point,
> or worse coverity once again starting to report a problem with the code
> because of a different issue.
> 
> You can try to come up with a commit message that justifies the change
> in a different way which would be accepted normally.
> (E.g. "making it obvious to the reader".)
> 
> 
Thank you for the comment.
Yes, I understand and I will send a v2 patch with the suggested commit message.

Regards,
Shaleen Bathla