[PATCH 00/15] Clean up credential asking code in SSH transport

Peter Krempa pkrempa at redhat.com
Tue Jan 17 16:20:25 UTC 2023


Peter Krempa (15):
  virNetLibsshSessionAuthAddPrivKeyAuth: Drop 'password' argument
  virNetLibsshAuthMethod: Drop 'password' field
  util: authconfig: Use automatic pointer clearing for virAuthConfig
  util: authconfig: Use conteporary and consistent header style
  virNetSSHSessionAuthAddPrivKeyAuth: Remove unused 'password' argument
  virNetSSHSessionAuthAddPrivKeyAuth: Refactor cleanup
  virNetSSHAuthMethod: Remove unused 'password' field
  virnetsshsession: Pass in username via virNetSSHSessionNew rather than
    auth functions
  util: auth: Introduce virAuthAskCredential
  virNetLibsshAuthenticateKeyboardInteractive: Use virAuthAskCredential
  virNetLibsshAuthenticatePrivkeyCb: Use virAuthAskCredential
  util: virauth: Export virAuthGetCredential
  virNetLibsshCheckHostKey: Use virAuthAskCredential
  virNetLibsshAuthenticatePassword: Use virAuthAskPassword instead of
    virAuthGetPasswordPath
  virAuthGetPasswordPath: Use virAuthAskCredential for callback
    interaction

 src/libvirt_private.syms      |   3 +
 src/rpc/virnetlibsshsession.c | 211 ++++++++++------------------------
 src/rpc/virnetlibsshsession.h |   3 +-
 src/rpc/virnetsocket.c        |  19 +--
 src/rpc/virnetsshsession.c    | 162 ++++++++------------------
 src/rpc/virnetsshsession.h    |  13 +--
 src/util/virauth.c            | 107 +++++++++++------
 src/util/virauth.h            |  12 ++
 src/util/virauthconfig.c      |  52 ++++-----
 9 files changed, 223 insertions(+), 359 deletions(-)

-- 
2.38.1



More information about the libvir-list mailing list