[PATCH 06/15] vbox: Drop @data and @name from UIHost::CreateHostOnlyNetworkInterface()

Michal Privoznik mprivozn at redhat.com
Mon Jan 23 09:34:15 UTC 2023


The @data and @name arguments of
UIHost::CreateHostOnlyNetworkInterface() callback are unused.
Drop them and also their propagation from parent functions.

Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
---
 src/vbox/vbox_network.c       | 3 +--
 src/vbox/vbox_tmpl.c          | 3 +--
 src/vbox/vbox_uniformed_api.h | 3 +--
 3 files changed, 3 insertions(+), 6 deletions(-)

diff --git a/src/vbox/vbox_network.c b/src/vbox/vbox_network.c
index c3dea66102..f369e466ab 100644
--- a/src/vbox/vbox_network.c
+++ b/src/vbox/vbox_network.c
@@ -429,8 +429,7 @@ vboxNetworkDefineCreateXML(virConnectPtr conn, const char *xml, bool start,
      * NULL. (We can't assign a new name to hostonly network, only
      * take the given name, say vboxnet0)
      */
-    gVBoxAPI.UIHost.CreateHostOnlyNetworkInterface(data, host, def->name,
-                                                   &networkInterface);
+    gVBoxAPI.UIHost.CreateHostOnlyNetworkInterface(host, &networkInterface);
 
     if (!networkInterface)
         goto cleanup;
diff --git a/src/vbox/vbox_tmpl.c b/src/vbox/vbox_tmpl.c
index f8c3fbbdb9..dac195bf49 100644
--- a/src/vbox/vbox_tmpl.c
+++ b/src/vbox/vbox_tmpl.c
@@ -2003,8 +2003,7 @@ _hostFindHostNetworkInterfaceByName(IHost *host, PRUnichar *name,
 }
 
 static nsresult
-_hostCreateHostOnlyNetworkInterface(struct _vboxDriver *data G_GNUC_UNUSED,
-                                    IHost *host, char *name G_GNUC_UNUSED,
+_hostCreateHostOnlyNetworkInterface(IHost *host,
                                     IHostNetworkInterface **networkInterface)
 {
     nsresult rc = -1;
diff --git a/src/vbox/vbox_uniformed_api.h b/src/vbox/vbox_uniformed_api.h
index b5a71a338c..3a9c317092 100644
--- a/src/vbox/vbox_uniformed_api.h
+++ b/src/vbox/vbox_uniformed_api.h
@@ -453,8 +453,7 @@ typedef struct {
                                              IHostNetworkInterface **networkInterface);
     nsresult (*FindHostNetworkInterfaceByName)(IHost *host, PRUnichar *name,
                                                IHostNetworkInterface **networkInterface);
-    nsresult (*CreateHostOnlyNetworkInterface)(struct _vboxDriver *driver,
-                                               IHost *host, char *name,
+    nsresult (*CreateHostOnlyNetworkInterface)(IHost *host,
                                                IHostNetworkInterface **networkInterface);
     nsresult (*RemoveHostOnlyNetworkInterface)(IHost *host, vboxIID *iid,
                                                IProgress **progress);
-- 
2.39.1



More information about the libvir-list mailing list