[PATCH v2 2/3] virprocess: Make virProcessGetStatInfo() fail if unable to parse data

[Michal Prívozník]

On 1/19/23 15:15, Martin Kletzander wrote:
> On Wed, Jan 18, 2023 at 10:58:18AM +0100, Michal Privoznik wrote:
>> Yeah, we've already seen this commit (v8.0.0-rc2~4) and also its
>> revert (v8.1.0-rc1~345). While the original idea was sound, the
>> implementation was less so and it changed behaviour of some
>> public APIs (e.g. whilst getting stats for a running guest was
>> best effort it started to return errors).
>>
> 
> With this patch virsh dominfo will fail for all running qemu and ch
> domains on non-Linux.  Also virDomainGetVcpus in some cases, although
> that is (maybe) not used that much?  The question is do we want it to
> fail if the strings cannot be parsed or something more sinister than
> just the system not being supported?  Maybe just ignoring the error is
> fine since that is how it used to work before.

Fair enough. I'll drop this. We can argue that users are probably used
to seeing zeros anyway (on non-Linux) by now.

Michal