[libvirt PATCH 2/4] remote: Drop useless check in remoteDispatchDomainGetIOThreadInfo

[Ján Tomko]

On a Thursday in 2023, Jiri Denemark wrote:
>Signed-off-by: Jiri Denemark <jdenemar at redhat.com>
>---

Can you elaborate on why you find this useless?

> src/remote/remote_daemon_dispatch.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
>diff --git a/src/remote/remote_daemon_dispatch.c b/src/remote/remote_daemon_dispatch.c
>index 4d993afee6..dbe6825fb8 100644
>--- a/src/remote/remote_daemon_dispatch.c
>+++ b/src/remote/remote_daemon_dispatch.c
>@@ -2968,9 +2968,8 @@ remoteDispatchDomainGetIOThreadInfo(virNetServer *server G_GNUC_UNUSED,
>     if (rv < 0)
>         virNetMessageSaveError(rerr);
>     virObjectUnref(dom);
>-    if (ninfo >= 0)

If ninfo is less than zero

>-        for (i = 0; i < ninfo; i++)

it will get promoted to unsigned here and the loop will take a long
time, freeing some fun stuff in the meantime.

Jano

>-            virDomainIOThreadInfoFree(info[i]);
>+    for (i = 0; i < ninfo; i++)
>+        virDomainIOThreadInfoFree(info[i]);
>     VIR_FREE(info);
>
>     return rv;
>-- 
>2.39.1
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20230126/fcbd895f/attachment.sig>