[libvirt PATCH v2 0/8] Extract the integration job commands to a shell script

Erik Skultety eskultet at redhat.com
Fri Jan 27 09:26:48 UTC 2023


Using shell scripts rather than inlining shell commands to YAML feels more
natural, more readable, and will keep all different variations of execution
consistent. Essentially the only disadvantage is that we won't see each command
listed one-by-one in gitlab's log output (unless we set -x that is), but given
that shell would complain if something was wrong with the script, it's fairly
easy to identify the problem.

Here's a test pipeline after the change:
https://gitlab.com/eskultety/libvirt/-/pipelines/759277200

Since v1:
- 3/7 - reworded commit message as requested
- 4/7 was dropped
- point the SCRATCH_DIR to /var/tmp instead of /tmp to not be limited by the
size of ramdisk mounted in there

Erik Skultety (8):
  syntax-check: Drop the shell's 'check for minus' rule
  ci: Move the SCRATCH_DIR from /tmp
  ci: integration: Extract several hidden job definitions to a script
  ci: integration: Drop the 'install-deps' hidden job and reference
  ci: integration-template: Drop the '-lt Fedora 35' check
  ci: integration.sh: Add/Rewrite/Reformat commentaries
  ci: integration.sh: Replace 'test' with '[' operator
  ci: integration.sh: Define the SCRATCH_DIR variable for local
    execution

 build-aux/syntax-check.mk   |  9 --------
 ci/integration-template.yml | 44 +++--------------------------------
 ci/integration.sh           | 46 +++++++++++++++++++++++++++++++++++++
 3 files changed, 49 insertions(+), 50 deletions(-)
 create mode 100644 ci/integration.sh

-- 
2.39.1



More information about the libvir-list mailing list