[PATCH 10/10] qemuTestDriverInit: Don't autopopulate qemu capabilities when initializing driver

Peter Krempa pkrempa at redhat.com
Tue Jul 4 13:40:19 UTC 2023


In an effort to use strictly real capability testing all tests were
converted to do insertion of their own capabilities when required, thus
we don't need to popluate the capabilities. This will also promote using
proper capabilities based on what the test is trying to achieve.

Signed-off-by: Peter Krempa <pkrempa at redhat.com>
---
 tests/testutilsqemu.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/tests/testutilsqemu.c b/tests/testutilsqemu.c
index e0b58b1d5d..16b773a768 100644
--- a/tests/testutilsqemu.c
+++ b/tests/testutilsqemu.c
@@ -428,7 +428,6 @@ int qemuTestDriverInit(virQEMUDriver *driver)
     virSecurityManager *mgr = NULL;
     char statedir[] = STATEDIRTEMPLATE;
     char configdir[] = CONFIGDIRTEMPLATE;
-    g_autoptr(virQEMUCaps) emptyCaps = NULL;

     memset(driver, 0, sizeof(*driver));

@@ -499,11 +498,6 @@ int qemuTestDriverInit(virQEMUDriver *driver)
     if (!driver->xmlopt)
         goto error;

-    /* Populate the capabilities cache with fake empty caps */
-    emptyCaps = virQEMUCapsNew();
-    if (qemuTestCapsCacheInsert(driver->qemuCapsCache, emptyCaps) < 0)
-        goto error;
-
     if (!(mgr = virSecurityManagerNew("none", "qemu",
                                       VIR_SECURITY_MANAGER_PRIVILEGED)))
         goto error;
-- 
2.41.0



More information about the libvir-list mailing list