[PATCH 2/2] tests: Refresh valgrind suppressions

[Peter Krempa]

On Wed, Jul 19, 2023 at 14:31:24 +0200, Michal Prívozník wrote:
> On 7/19/23 12:50, Peter Krempa wrote:
> > On Tue, Jul 18, 2023 at 14:28:57 +0200, Michal Privoznik wrote:
> >> Since nobody is expected to run valgrind over scripts now, we can
> >> drop plenty of suppressions. Also, there are some old ones that
> >> no longer exist and new ones, that are not covered.
> >>
> >> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
> >> ---
> >>  tests/.valgrind.supp | 188 ++++++++++---------------------------------
> >>  1 file changed, 41 insertions(+), 147 deletions(-)
> > 
> > Is it really worth keeping this file in the repository? I don't think
> > we can keep it current.
> > 
> 
> We have valgrind test setup (add_test_setup() in tests/meson.build) that
> passes this file. What we could have is a configure option that
> specifies where the file is so that everybody can keep a copy specific
> to their system. Would that work?

If we invoke it from the testsuite then I guess it makes sense to
distribute it. Arguably we could make it empty or contain a comment
saying what to put there.

Reviewed-by: Peter Krempa <pkrempa at redhat.com>