[PATCH 14/18] qemu: Refuse setting <iotune> for 'SD' disks

[Ján Tomko]

On a Thursday in 2023, Peter Krempa wrote:
>Historically this didn't work with any supported qemu version as we
>don't set the alias of the device, and thus qemu uses a different alias
>resulting in a failure to startup the VM:
>
>  internal error: unable to execute QEMU command 'block_set_io_throttle': Device 'drive-sd-disk0' not found
>
>Refuse setting throttling as this is unlikely to be needed and proper
>fix requires using -device instead of -drive if=sd.
>
>Note that this was broken when I moved the setup of throttling as a
>command at startup for blockdev integration quite a while ago. Until
>then throttling was passed as arguments for -drive.
>
>Signed-off-by: Peter Krempa <pkrempa at redhat.com>
>---
> src/qemu/qemu_driver.c   | 17 +++++++++--------
> src/qemu/qemu_validate.c |  8 ++++++++
> 2 files changed, 17 insertions(+), 8 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20230602/164dd73d/attachment.sig>