[libvirt PATCH 02/20] gitlab-ci.yml: potfile: Consolidate the meson compile calls

Daniel P. Berrangé berrange at redhat.com
Thu Mar 2 19:56:15 UTC 2023


On Mon, Feb 06, 2023 at 02:52:59PM +0100, Erik Skultety wrote:
> You can specify multiple targets at once for the 'compile' command.
> 
> Signed-off-by: Erik Skultety <eskultet at redhat.com>
> ---
>  .gitlab-ci.yml | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
> index 699be460ca..e20d0b9be8 100644
> --- a/.gitlab-ci.yml
> +++ b/.gitlab-ci.yml
> @@ -153,8 +153,7 @@ potfile:
>      - *script_variables
>    script:
>      - meson setup build --werror || (cat build/meson-logs/meson-log.txt && exit 1)
> -    - meson compile -C build libvirt-pot-dep
> -    - meson compile -C build libvirt-pot
> +    - meson compile -C build libvirt-pot-dep libvirt-pot

while possible i think its better to keep them separate so when
things fail you see which of the two commands was the failure
straight away.

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|


More information about the libvir-list mailing list