[libvirt PATCH 07/20] ci: build.sh: Drop the CI prefix from the CI_{MESON, NINJA}_ARGS vars

Daniel P. Berrangé berrange at redhat.com
Thu Mar 2 20:01:36 UTC 2023


On Mon, Feb 06, 2023 at 02:53:04PM +0100, Erik Skultety wrote:
> Although it is currently consistent with the other variables we define
> when running ci in a local container environment, it isn't consistent
> with the variable naming we use in GitLab recipes. Since the idea is
> to unite the two, we're likely going to drop a few other variables from
> the local env configuration anyway, hence this renaming.

The namespacing originated with & was only relevant when we were
still using the old automake system, as it let is 'include ci/Makefile'
without risk of it clashing with automake variables. So yeah, fine for
it to go.

> Signed-off-by: Erik Skultety <eskultet at redhat.com>
> ---
>  ci/Makefile | 4 ++--
>  ci/build.sh | 4 ++--
>  ci/helper   | 4 ++--
>  3 files changed, 6 insertions(+), 6 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange at redhat.com>


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|


More information about the libvir-list mailing list