[PATCH 0/6] qemuBuildHostNetProps: Properly handle unsupported netdevs and remove virJSONValueObjectAppendStringPrintf

Ján Tomko jtomko at redhat.com
Mon Mar 6 09:53:30 UTC 2023


On a Monday in 2023, Peter Krempa wrote:
>First patch fixes a crasher if unsupported network device is used and
>subsequently virJSONValueObjectAppendStringPrintf is removed.
>
>Peter Krempa (6):
>  qemuBuildHostNetProps: Report proper errors for unhandled interface
>    types
>  qemuBuildHostNetProps: Don't use virJSONValueObjectAppendStringPrintf
>    to format address
>  qemuBuildChannelGuestfwdNetdevProps: Don't use
>    virJSONValueObjectAppendStringPrintf
>  qemuBuildHostNetProps: Append ipv6 address using virJSONValueObjectAdd
>  qemuBuildHostNetProps: Append aliases without
>    virJSONValueObjectAppendStringPrintf
>  util: json: Remove unused virJSONValueObjectAppendStringPrintf
>
> src/libvirt_private.syms |   1 -
> src/qemu/qemu_command.c  | 113 +++++++++++++++++++++++++--------------
> src/util/virjson.c       |  17 ------
> src/util/virjson.h       |   6 ---
> 4 files changed, 74 insertions(+), 63 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20230306/c2f32c75/attachment.sig>


More information about the libvir-list mailing list