[PATCH 01/15] qemu: validate: Fix logic for validating precence of the HPET timer

Ján Tomko jtomko at redhat.com
Tue Mar 7 09:30:35 UTC 2023


In the commit summary:

s/precence/presence/

On a Monday in 2023, Peter Krempa wrote:
>Commit 24cc9cda826 switched over to use -machine hpet, but one of the
>steps it did was to clear the QEMU_CAPS_NO_HPET capability.
>
>The validation check still uses the old capability though which means
>that for configs which would explicitly enable HPET we'd report an error.
>
>Since HPET is an x86(_64) platform specific device, convert the
>validation check to an architecture check as all supported qemu versions
>actually support it.
>
>Modify a test case to request HPET to catch posible future problems.
>
>Fixes: 24cc9cda826
>Signed-off-by: Peter Krempa <pkrempa at redhat.com>
>---
> src/qemu/qemu_validate.c                           | 14 +++++++-------
> .../q35-virt-manager-basic.x86_64-4.2.0.args       |  1 -
> .../q35-virt-manager-basic.x86_64-latest.args      |  2 +-
> tests/qemuxml2argvdata/q35-virt-manager-basic.xml  |  2 +-
> .../q35-virt-manager-basic.x86_64-latest.xml       |  2 +-
> 5 files changed, 10 insertions(+), 11 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20230307/27a927f9/attachment.sig>


More information about the libvir-list mailing list