[libvirt PATCH] remote: add mutex when freeing private callbacks

Martin Kletzander mkletzan at redhat.com
Tue Mar 7 20:42:30 UTC 2023


On Tue, Mar 07, 2023 at 08:22:25AM -0800, Mike Pontillo wrote:
>On Tue, Mar 7, 2023, 00:59 Martin Kletzander <mkletzan at redhat.com> wrote:
>> Good catch, we can make it even slicker with:
>>
>>    VIR_LOCK_GUARD lock = virLockGuardLock(&priv->lock);
>>
>> and rely on automatic unlock at the return.  Either way (let me know if
>> you're OK with the proposed change):
>
>Thanks for the review; I'll look at amending the patch to do this. (This
>patch was originally written for a version of libvirt where this macro
>did not yet exist!)
>

I can do that before pushing if you are OK with it, I'll keep your S-o-b.

>Thanks,
>Mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20230307/e31da9b7/attachment.sig>


More information about the libvir-list mailing list