[libvirt PATCH 3/4] qemu: do not require bits for maxphysaddr mode emulate

[Peter Krempa]

On Wed, Mar 01, 2023 at 13:34:34 +0100, Ján Tomko wrote:
> Make the bits attribute optional.
> 
> Signed-off-by: Ján Tomko <jtomko at redhat.com>
> ---
>  docs/formatdomain.rst                         |  3 +-
>  src/qemu/qemu_validate.c                      |  7 -----
>  .../cpu-phys-bits-emulate-bare.xml            | 20 ++++++++++++
>  .../cpu-phys-bits-emulate3.err                |  1 -
>  .../cpu-phys-bits-emulate3.xml                | 20 ------------
>  tests/qemuxml2argvtest.c                      |  1 -
>  ...u-phys-bits-emulate-bare.x86_64-latest.xml | 31 +++++++++++++++++++
>  tests/qemuxml2xmltest.c                       |  1 +
>  8 files changed, 54 insertions(+), 30 deletions(-)
>  create mode 100644 tests/qemuxml2argvdata/cpu-phys-bits-emulate-bare.xml
>  delete mode 100644 tests/qemuxml2argvdata/cpu-phys-bits-emulate3.err
>  delete mode 100644 tests/qemuxml2argvdata/cpu-phys-bits-emulate3.xml
>  create mode 100644 tests/qemuxml2xmloutdata/cpu-phys-bits-emulate-bare.x86_64-latest.xml
> 
> diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst
> index 29854037a9..ae482d7905 100644
> --- a/docs/formatdomain.rst
> +++ b/docs/formatdomain.rst
> @@ -1615,7 +1615,8 @@ In case no restrictions need to be put on CPU model and its features, a simpler
>           passed through to the virtual CPUs
>        ``emulate``
>           The hypervisor will define a specific value for the number of bits
> -         of physical addresses via the ``bits`` attribute, which is mandatory.
> +         of physical addresses via the ``bits`` attribute, which is optional
> +         :since:`since 9.2.0`

I'm lacking a justification or explanation why this is done.