[libvirt PATCH 4/8] vbox: remove unreachable error in virVBoxSnapshotConfLoadVboxFile

Ján Tomko jtomko at redhat.com
Sat Mar 18 13:38:23 UTC 2023


Both callers in the VirtualBox driver error out if the path
can't be fetched via VirtualBox APIs and abort on coversion error
from UTF-16 to UTF-8.

Signed-off-by: Ján Tomko <jtomko at redhat.com>
---
 src/vbox/vbox_snapshot_conf.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/src/vbox/vbox_snapshot_conf.c b/src/vbox/vbox_snapshot_conf.c
index 2f3f48d688..a6e5fad4d2 100644
--- a/src/vbox/vbox_snapshot_conf.c
+++ b/src/vbox/vbox_snapshot_conf.c
@@ -576,12 +576,6 @@ virVBoxSnapshotConfLoadVboxFile(const char *filePath,
     ssize_t searchResultSize = 0;
     char *currentSnapshotAttribute = NULL;
 
-    if (filePath == NULL) {
-        virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
-                       _("Filepath is Null"));
-        goto cleanup;
-    }
-
     machineDescription = g_new0(virVBoxSnapshotConfMachine, 1);
 
     xml = virXMLParse(filePath, NULL, NULL, NULL, &xPathContext, NULL, false);
-- 
2.39.2



More information about the libvir-list mailing list