[PATCH v2] meson: Stop detecting -Wl,--version-script=

[Daniel P. Berrangé]

On Tue, Mar 21, 2023 at 11:00:16AM +0100, Michal Privoznik wrote:
> With its version 16.0, the LLVM's linker turned on
> --no-undefined-version by default [1]. This breaks how we detect
> --version-script= detection, because at the compile time there's
> no library built yet that we can use to make --version-script=
> happy. Unfortunately, meson does not provide a way to detect this
> either [2].
> 
> But there's not much sense in detecting the argument either. We
> already special case some systems (windows, darwin) and do the
> check for others, which are expected to support versioned
> symbols, because of ELF. Worst case scenario - the error is
> reported during compile time rather than configure time.
> 
> 1: https://reviews.llvm.org/D135402
> 2: https://github.com/mesonbuild/meson/issues/3047
> 
> Resolves: https://bugs.gentoo.org/902211
> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
> ---
> 
> v2 of:
> 
> https://listman.redhat.com/archives/libvir-list/2023-March/238923.html
> 
> diff to v1:
> - Instead of fixing the detection, drop it completely.
> 
>  meson.build | 7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange at redhat.com>


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|