[PATCH v2 0/6] Introduce active RBD disk snapshot support

[Or Ozeri]

Hi Peter,

I'm missing some clarifications here:
https://listman.redhat.com/archives/libvir-list/2023-March/238546.html
https://listman.redhat.com/archives/libvir-list/2023-March/238548.html

Could you please have a look?

Thanks,
Or

> -----Original Message-----
> From: Peter Krempa <pkrempa at redhat.com>
> Sent: Monday, 20 February 2023 16:24
> To: Or Ozeri <ORO at il.ibm.com>
> Cc: libvir-list at redhat.com; Danny Harnik <DANNYH at il.ibm.com>; Pavel
> Hrdina <phrdina at redhat.com>
> Subject: [EXTERNAL] Re: [PATCH v2 0/6] Introduce active RBD disk snapshot
> support
> 
> On Wed, Feb 15, 2023 at 05:28:16 -0600, Or Ozeri wrote:
> > Internal disk snapshots are currently only supported on non-active VMs.
> > For RBD disks only, this patch series extends this support for active VMs
> running with qemu.
> > We also add the option to set a name for each RBD snapshot, and allow
> taking them alongside other external disk snapshots (mixing).
> > Deletion and reverting to snapshots containing RBD snapshots is not
> allowed, and is validated.
> > Note that taking RBD snapshots on a non-active VM is still unsupported.
> >
> > Changes in v2:
> >     - reduce patch to RBD use-case only (e.g. not including qcow2 internal
> snapshots)
> >     - add validation to disallow RBD snapshots deletion / reverting
> >
> > Or Ozeri (6):
> >   conf: Add snapshotName attribute for internal disk snapshot
> >   qemu: Block deletion and reverting on non-full internal snapshots
> >   qemu: Add internal support for active disk internal snapshots
> >   qemu: Allow active disk snapshots for RBD disks
> >   qemu: Allow setting per-disk snapshot name for RBD disks
> >   qemu: Allow mixing active internal and external active disk
> > snapshots
> 
> Note that also Pavel (CC'd) might want to add more comments as he's
> currently working on the snapshot code.