[PATCH] Revert "ci: Disable optimization on macos-12"
Michal Prívozník
mprivozn at redhat.com
Fri Mar 24 16:05:31 UTC 2023
On 3/24/23 16:54, Martin Kletzander wrote:
> This reverts commit 1f76b5365ec78b1e9a36038db8e13ec0025bbe7a.
>
> There were two issues with this commit. First is the missing propagation
> of CFLAGS into the build environment and second is the fact that this is
> not enough to disable the check for -fsemantic-interposition. The
> proper fix would require setting MESON_OPTS or similar and also add the
> propagation of such variable into the cirrus builds etc., but at this
> point I burned so much time on this trivial piece of rubbish that I
> think it's easier to just wait for macos to gain a newer clang =D
>
> Signed-off-by: Martin Kletzander <mkletzan at redhat.com>
> ---
> ci/gitlab/builds.yml | 1 -
> ci/manifest.yml | 2 --
> 2 files changed, 3 deletions(-)
Yeah, sorry for setting you on a misleading path.
Reviewed-by: Michal Privoznik <mprivozn at redhat.com>
if my ACK still counts...
Michal
More information about the libvir-list
mailing list