[PATCH] storage_file_probe: change maximum len value in vmdk4GetBackingStore

Ján Tomko jtomko at redhat.com
Wed Mar 29 10:44:01 UTC 2023


On a Wednesday in 2023, Анастасия Белова wrote:
>From: Anastasia Belova <abelova at astralinux.ru>
>
>desc length should be always less than VIR_STORAGE_MAX_HEADER.
>If len = VIR_STORAGE_MAX_HEADER, desc may be out of bounds.
>
>Fixes: 296032bfb2 ("util: extract storage file probe code into virtstoragefileprobe.c")

That commit only moved the code.
The off-by-one error was introduced by:
commit 348b4e254bea98c83107887c0cf64c6572063d64
     storage: always probe type with buffer

>Signed-off-by: Anastasia Belova <abelova at astralinux.ru>
>---
> src/storage_file/storage_file_probe.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20230329/82e1cb57/attachment.sig>


More information about the libvir-list mailing list