[PATCH 21/31] qemuhotplugtest: Make the test more useful by validating used commands against QMP schema

Peter Krempa pkrempa at redhat.com
Thu Mar 30 13:38:15 UTC 2023


qemuhotplugtest validates only that a given command is used but not the
arguments of the command. With this patch we'll validate the arguments
against the QMP schema thus we can catch possible issues with deprecated
commands.

Signed-off-by: Peter Krempa <pkrempa at redhat.com>
---
 tests/qemuhotplugtest.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/tests/qemuhotplugtest.c b/tests/qemuhotplugtest.c
index 9c8407c5ef..63a6833cfd 100644
--- a/tests/qemuhotplugtest.c
+++ b/tests/qemuhotplugtest.c
@@ -57,6 +57,7 @@ struct qemuHotplugTestData {
     GHashTable *capsLatestFiles;
     GHashTable *capsCache;
     GHashTable *schemaCache;
+    GHashTable *schema;
 };

 static int
@@ -342,7 +343,7 @@ testQemuHotplug(const void *data)
         if (qemuHotplugCreateObjects(driver.xmlopt, &vm, domain_xml,
                                      test->arch, test->capsLatestFiles,
                                      test->capsCache, test->schemaCache,
-                                     NULL) < 0)
+                                     &test->schema) < 0)
             goto cleanup;
     }

@@ -356,7 +357,7 @@ testQemuHotplug(const void *data)

     /* Now is the best time to feed the spoofed monitor with predefined
      * replies. */
-    if (!(test_mon = qemuMonitorTestNew(driver.xmlopt, vm, NULL, NULL)))
+    if (!(test_mon = qemuMonitorTestNew(driver.xmlopt, vm, NULL, test->schema)))
         goto cleanup;

     tmp = test->mon;
-- 
2.39.2



More information about the libvir-list mailing list