[libvirt PATCH] util: Improve comment for workaround

Andrea Bolognani abologna at redhat.com
Thu May 4 16:08:35 UTC 2023


Now that a version of GLib that contains the fix has been
released, it's more useful to record that information. Adding
a TODO annotation makes the whole thing easily greppable.

Signed-off-by: Andrea Bolognani <abologna at redhat.com>
---
 src/util/virfile.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/src/util/virfile.c b/src/util/virfile.c
index 657e74e026..228482e8f8 100644
--- a/src/util/virfile.c
+++ b/src/util/virfile.c
@@ -1747,8 +1747,7 @@ virFindFileInPath(const char *file)
         return NULL;
 
     /* Workaround for a bug in g_find_program_in_path() not returning absolute
-     * path as documented.  This has been fixed in
-     * https://gitlab.gnome.org/GNOME/glib/-/merge_requests/2127
+     * path as documented. TODO drop it once we require GLib >= 2.69.0
      */
     return g_canonicalize_filename(path, NULL);
 }
-- 
2.40.1



More information about the libvir-list mailing list