[PATCH] logging: Provide empty VIRTLOGD_ARGS in the unit file

Ján Tomko jtomko at redhat.com
Tue May 9 11:05:58 UTC 2023


On a Tuesday in 2023, Michal Privoznik wrote:
>For all our daemons, we provide VIRXXXD_ARGS env var in the unit
>file. The variable can then be overridden in corresponding file:
>
>  EnvironmentFile=- at initconfdir@/virtxxxd
>
>The daemon is then executed as:
>
>  ExecStart=@sbindir@/virtxxxd $VIRTXXXD_ARGS
>
>But virlogd is exception, for no good reason. And while there are

s/virlogd/virtlogd/

>probably no arguments we want to pass to virtlogd by default,
>just mimic what we do for say virtlockd, where we also don't pass
>any default argument.
>
>Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
>---
> src/logging/virtlogd.service.in | 1 +
> 1 file changed, 1 insertion(+)
>

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20230509/4900e1a4/attachment.sig>


More information about the libvir-list mailing list