[PATCH 09/22] qemublocktest: Use "target only" mode in 'testJSONtoJSON' and 'testBackingXMLjsonXML'

Ján Tomko jtomko at redhat.com
Wed Oct 25 14:34:03 UTC 2023


On a Wednesday in 2023, Peter Krempa wrote:
>Both tests pass a disk source definition which didn't go through the
>preparation steps and thus contains only the target information that
>were originally present, thus we should be using the
>QEMU_BLOCK_STORAGE_SOURCE_BACKEND_PROPS_TARGET_ONLY flag.
>
>For the same reason QEMU_BLOCK_STORAGE_SOURCE_BACKEND_PROPS_AUTO_READONLY
>used in 'testJSONtoJSON' doesn't make sense.
>
>Signed-off-by: Peter Krempa <pkrempa at redhat.com>
>---
> tests/qemublocktest.c                                        | 4 ++--
> tests/qemublocktestdata/jsontojson/curl-libguestfs-out.json  | 5 ++---
> .../jsontojson/ssh-passthrough-libguestfs-out.json           | 4 +---
> 3 files changed, 5 insertions(+), 8 deletions(-)
>

For patches 1 to 9/22

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20231025/a4abbda1/attachment.sig>


More information about the libvir-list mailing list