[PATCH] conf, schema: Switch iothread/poll values to unsignedLong
Peter Krempa
pkrempa at redhat.com
Mon Sep 4 07:22:54 UTC 2023
On Fri, Sep 01, 2023 at 23:32:14 +0200, Martin Kletzander wrote:
> They represent nanoseconds, and we accept such values already. Not that
> anyone would use such values in the wild, but even one person testing
> QEMU could put in a bigger value and will be bothered with validation
> errors after every `virsh edit`. Also add a test for it.
>
> Resolves: https://issues.redhat.com/browse/RHEL-1717
>
> Signed-off-by: Martin Kletzander <mkletzan at redhat.com>
> ---
> src/conf/schemas/domaincommon.rng | 6 +++---
> tests/genericxml2xmlindata/iothreadids.xml | 23 ++++++++++++++++++++++
> tests/genericxml2xmltest.c | 2 ++
> 3 files changed, 28 insertions(+), 3 deletions(-)
> create mode 100644 tests/genericxml2xmlindata/iothreadids.xml
>
> diff --git a/src/conf/schemas/domaincommon.rng b/src/conf/schemas/domaincommon.rng
> index de3bd1c35c55..2f9ba31c0aec 100644
> --- a/src/conf/schemas/domaincommon.rng
> +++ b/src/conf/schemas/domaincommon.rng
> @@ -876,17 +876,17 @@
> <element name="poll">
> <optional>
> <attribute name="max">
> - <ref name="unsignedInt"/>
> + <ref name="unsignedLong"/>
> </attribute>
I've looked originally at 'src/conf/schemas/basictypes.rng' which has:
<define name="unsignedInt">
<data type="unsignedInt">
<param name="pattern">[0-9]+</param>
</data>
</define>
And concluded that there's no actual difference between that and
'unsignedLong' not realizing that this is not the full definition of the
type.
> </optional>
> <optional>
> <attribute name="grow">
Reviewed-by: Peter Krempa <pkrempa at redhat.com>
More information about the libvir-list
mailing list