[PATCH 8/8] build: Decrease maximum stack frame size to 2048
Michal Prívozník
mprivozn at redhat.com
Mon Sep 4 14:09:00 UTC 2023
On 8/30/23 13:59, Peter Krempa wrote:
> After recent cleanups we can now restrict the maximum stack frame size
> to 2k.
>
> Signed-off-by: Peter Krempa <pkrempa at redhat.com>
> ---
> meson.build | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meson.build b/meson.build
> index 965ada483b..e45f3e2c39 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -248,7 +248,7 @@ alloc_max = run_command(
> )
>
> # sanitizer instrumentation may enlarge stack frames
> -stack_frame_size = get_option('b_sanitize') == 'none' ? 4096 : 32768
> +stack_frame_size = get_option('b_sanitize') == 'none' ? 2048 : 32768
>
> # array_bounds=2 check triggers false positive on some GCC
> # versions when using sanitizers. Seen on Fedora 34 with
I know this is already pushed but to be honest, I don't really
understand why this is needed. I mean, we certainly do not want large
frames, but IIUC only frames larger than a page are problem (i.e. 4KiB).
Can you please point me to some docs where I can learn more?
Michal
More information about the libvir-list
mailing list