[PATCH 08/16] virsh: Add helper method to retrieve xml from NWFilter def

Michal Prívozník mprivozn at redhat.com
Tue Sep 19 13:19:55 UTC 2023


On 9/3/23 17:49, K Shiva Kiran wrote:
> Signed-off-by: K Shiva Kiran <shiva_kr at riseup.net>
> ---
>  tools/virsh-util.c | 25 +++++++++++++++++++++++++
>  tools/virsh-util.h |  9 +++++++++
>  2 files changed, 34 insertions(+)
> 


> diff --git a/tools/virsh-util.h b/tools/virsh-util.h
> index 2386847072..4cad3d7eb9 100644
> --- a/tools/virsh-util.h
> +++ b/tools/virsh-util.h
> @@ -152,6 +152,15 @@ virshNetworkGetXMLFromNet(vshControl *ctl,
>      ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(2) ATTRIBUTE_NONNULL(4)
>      ATTRIBUTE_NONNULL(5) G_GNUC_WARN_UNUSED_RESULT;
>  
> +int
> +virshNWFilterGetXMLFromNWFilter(vshControl *ctl,
> +                                virNWFilterPtr nwfilter,
> +                                unsigned int flags,
> +                                xmlDocPtr *xml,
> +                                xmlXPathContextPtr *ctxt)
> +    ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(2) ATTRIBUTE_NONNULL(4)
> +    ATTRIBUTE_NONNULL(5) G_GNUC_WARN_UNUSED_RESULT;
> +

Looking into the future, there's just one user of this function. Please
consider merging this patch into the next one.

Michal



More information about the libvir-list mailing list