[PATCH 06/16] nwfilter: Introduce public API to retrieve user-defined metadata
Michal Prívozník
mprivozn at redhat.com
Tue Sep 19 13:20:04 UTC 2023
On 9/3/23 17:49, K Shiva Kiran wrote:
> Introduces `virNWFilterGetMetadata()` to retrieve user defined
> metadata fields, i.e `<title>`, `<description>` and `<metadata>`
>
> Signed-off-by: K Shiva Kiran <shiva_kr at riseup.net>
> ---
> include/libvirt/libvirt-nwfilter.h | 5 +++
> src/driver-nwfilter.h | 6 +++
> src/libvirt-nwfilter.c | 67 ++++++++++++++++++++++++++++++
> src/libvirt_public.syms | 1 +
> 4 files changed, 79 insertions(+)
Alright, introducing setter and getter in two different APIs is a bit of
a stretch but I can live with it. Somebody might want just the setter
and use nwfilter-dumpxml as getter.
But then you implement RPC for both of these APIs in a single patch
(07/16). Therefore, please merge also 05 and 06.
Michal
More information about the libvir-list
mailing list