[libvirt PATCH 2/3] qemu: extend filesystem XML validation

[Ján Tomko]

On a Wednesday in 2023, Ján Tomko wrote:
>Reject readonly argument for virtiofs and quotas for all filesystems.
>
>https://issues.redhat.com/browse/RHEL-4994
>https://issues.redhat.com/browse/RHEL-4432
>
>Signed-off-by: Ján Tomko <jtomko at redhat.com>
>---
> src/qemu/qemu_validate.c | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
>diff --git a/src/qemu/qemu_validate.c b/src/qemu/qemu_validate.c
>index 8d2927af60..f02ed4d44e 100644
>--- a/src/qemu/qemu_validate.c
>+++ b/src/qemu/qemu_validate.c
>@@ -4264,6 +4264,13 @@ qemuValidateDomainDeviceDefFS(virDomainFSDef *fs,
>                        _("only supports mount filesystem type"));
>         return -1;
>     }
>+
>+    if (fs->space_hard_limit > 0 || space_soft_limit > 0) {

fs->space_soft_limit, of course

Jano

>+        virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
>+                       _("filesystem usage limits are not supported with QEMU"));
>+        return -1;
>+    }
>+
>     if (fs->multidevs != VIR_DOMAIN_FS_MULTIDEVS_DEFAULT &&
>         !virQEMUCapsGet(qemuCaps, QEMU_CAPS_FSDEV_MULTIDEVS)) {
>         virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20230920/57435730/attachment.sig>