[PATCH 10/31] gdbstub: Fix target.xml response

Alex Bennée alex.bennee at linaro.org
Mon Sep 25 14:48:33 UTC 2023


From: Akihiko Odaki <akihiko.odaki at daynix.com>

It was failing to return target.xml after the first request.

Fixes: 56e534bd11 ("gdbstub: refactor get_feature_xml")
Signed-off-by: Akihiko Odaki <akihiko.odaki at daynix.com>
Message-Id: <20230912224107.29669-3-akihiko.odaki at daynix.com>
Signed-off-by: Alex Bennée <alex.bennee at linaro.org>
---
 gdbstub/gdbstub.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gdbstub/gdbstub.c b/gdbstub/gdbstub.c
index 349d348c7b..384191bcb0 100644
--- a/gdbstub/gdbstub.c
+++ b/gdbstub/gdbstub.c
@@ -396,8 +396,8 @@ static const char *get_feature_xml(const char *p, const char **newp,
             g_string_append(xml, "</target>");
 
             process->target_xml = g_string_free(xml, false);
-            return process->target_xml;
         }
+        return process->target_xml;
     }
     /* Is it dynamically generated by the target? */
     if (cc->gdb_get_dynamic_xml) {
-- 
2.39.2



More information about the libvir-list mailing list