[libvirt PATCH 35/42] systemd: Replace Requires with BindTo+After for sockets
Andrea Bolognani
abologna at redhat.com
Mon Sep 25 18:58:33 UTC 2023
This is the strongest relationship that can be declared between
two units, and causes the service to be terminated immediately
if any of its sockets disappear. This is the behavior we want.
Signed-off-by: Andrea Bolognani <abologna at redhat.com>
---
src/locking/virtlockd.service.in | 6 ++++--
src/logging/virtlogd.service.in | 6 ++++--
src/virtd.service.in | 9 ++++++---
3 files changed, 14 insertions(+), 7 deletions(-)
diff --git a/src/locking/virtlockd.service.in b/src/locking/virtlockd.service.in
index 9e91fa3261..a21a2c2c19 100644
--- a/src/locking/virtlockd.service.in
+++ b/src/locking/virtlockd.service.in
@@ -1,7 +1,9 @@
[Unit]
Description=Virtual machine lock manager
-Requires=virtlockd.socket
-Requires=virtlockd-admin.socket
+BindsTo=virtlockd.socket
+BindsTo=virtlockd-admin.socket
+After=virtlockd.socket
+After=virtlockd-admin.socket
Before=libvirtd.service
Documentation=man:virtlockd(8)
Documentation=https://libvirt.org
diff --git a/src/logging/virtlogd.service.in b/src/logging/virtlogd.service.in
index 97c942ffb0..f3bd576301 100644
--- a/src/logging/virtlogd.service.in
+++ b/src/logging/virtlogd.service.in
@@ -1,7 +1,9 @@
[Unit]
Description=Virtual machine log manager
-Requires=virtlogd.socket
-Requires=virtlogd-admin.socket
+BindsTo=virtlogd.socket
+BindsTo=virtlogd-admin.socket
+After=virtlogd.socket
+After=virtlogd-admin.socket
Before=libvirtd.service
Documentation=man:virtlogd(8)
Documentation=https://libvirt.org
diff --git a/src/virtd.service.in b/src/virtd.service.in
index 21391a65b0..b9e6345e8c 100644
--- a/src/virtd.service.in
+++ b/src/virtd.service.in
@@ -1,8 +1,11 @@
[Unit]
Description=@name@ daemon
-Requires=@service at .socket
-Requires=@service at -ro.socket
-Requires=@service at -admin.socket
+BindsTo=@service at .socket
+BindsTo=@service at -ro.socket
+BindsTo=@service at -admin.socket
+After=@service at .socket
+After=@service at -ro.socket
+After=@service at -admin.socket
Conflicts=libvirtd.service
After=libvirtd.service
After=network.target
--
2.41.0
More information about the libvir-list
mailing list