[Libvirt-ci] Fixed: libvirt/libvirt#206 (master - 6451b55)

Travis CI builds at travis-ci.org
Fri Jun 16 13:09:04 UTC 2017


Build Update for libvirt/libvirt
-------------------------------------

Build: #206
Status: Fixed

Duration: 23 minutes and 33 seconds
Commit: 6451b55 (master)
Author: Michal Privoznik
Message: qemuDomainGetPreservedMounts: Fix suffixes for corner cases

https://bugzilla.redhat.com/show_bug.cgi?id=1431112

Imagine a FS mounted on /dev/blah/blah2. Our process of creating
suffix for temporary location where all the mounted filesystems
are moved is very simplistic. We want:

/var/run/libvirt/qemu/$domName.$suffix\

were $suffix is just the mount point path stripped of the "/dev/"
prefix. For instance:

/var/run/libvirt/qemu/fedora.mqueue  for /dev/mqueue
/var/run/libvirt/qemu/fedora.pts     for /dev/pts

and so on. Now if we plug /dev/blah/blah2 into the example we see
some misbehaviour:

/var/run/libvirt/qemu/fedora.blah/blah2

Well, misbehaviour if /dev/blah/blah2 is a file, because in that
case we call virFileTouch() instead of virFileMakePath().
The solution is to replace all the slashes in the suffix with say
dots. That way we don't have to care about nested directories.
IOW, the result we want for given example is:

/var/run/libvirt/qemu/fedora.blah.blah2

Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
Reviewed-by: John Ferlan <jferlan at redhat.com>

View the changeset: https://github.com/libvirt/libvirt/compare/cc9f0521cda6...6451b55ec3d8

View the full build log and details: https://travis-ci.org/libvirt/libvirt/builds/243652850?utm_source=email&utm_medium=notification

--

You can configure recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/libvirt-ci/attachments/20170616/6b627e05/attachment.htm>


More information about the Libvirt-ci mailing list