[Libvirt-ci] Errored: libvirt/libvirt#1566 (master - 0a476f1)

[Travis CI]

Build Update for libvirt/libvirt
-------------------------------------

Build: #1566
Status: Errored

Duration: 18 mins and 18 secs
Commit: 0a476f1 (master)
Author: Pavel Hrdina
Message: conf: Introduce virDomainDefPostParseMemtune

Previously we were ignoring "nodeset" attribute for hugepage pages
if there was no guest NUMA topology configured in the domain XML.
Commit <fa6bdf6afa878b8d7c5ed71664ee72be8967cdc5> partially fixed
that issue but it introduced a somehow valid regression.

In case that there is no guest NUMA topology configured and the
"nodeset" attribute is set to "0" it was accepted and was working
properly even though it was not completely valid XML.

This patch introduces a workaround that it will ignore the nodeset="0"
only in case that there is no guest NUMA topology in order not to
hit the validation error.

After this commit the following XML configuration is valid:

  <memoryBacking>
    <hugepages>
      <page size='2048' unit='KiB' nodeset='0'/>
    </hugepages>
  </memoryBacking>

but this configuration remains invalid:

  <memoryBacking>
    <hugepages>
      <page size='2048' unit='KiB' nodeset='0'/>
      <page size='1048576' unit='KiB'/>
    </hugepages>
  </memoryBacking>

The issue with the second configuration is that it was originally
working, however changing the order of the <page> elements resolved
into using different page size for the guest.  The code is written
in a way that it expect only one page configured and always uses only
the first page in case that there is no guest NUMA topology configured.
See qemuBuildMemPathStr() function for details.

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1591235

Signed-off-by: Pavel Hrdina <phrdina at redhat.com>

View the changeset: https://github.com/libvirt/libvirt/compare/5d40272ea67c...0a476f152150

View the full build log and details: https://travis-ci.org/libvirt/libvirt/builds/414569698?utm_source=email&utm_medium=notification

--

You can configure recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications







This email was sent to libvirt-ci at redhat.com (mailto:libvirt-ci at redhat.com)
unsubscribe from this list (http://clicks.travis-ci.com/track/unsub.php?u=14313403&id=a6460effde264e3295cc26b638fd9155.q3yTAF39gfjNcLjHva7iXjXSQZI%3D&r=https%3A%2F%2Fmandrillapp.com%2Funsub%3Fmd_email%3Dlibvirt-ci%2540redhat.com)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/libvirt-ci/attachments/20180810/e670e819/attachment.htm>