10 minutes and 27 seconds
|Michal Privoznik||979a7b3 Changeset →|
|qemuDomainAttachDeviceMknodHelper: Remove symlink before creating it
So imagine you have /dev/blah symlink which points to /dev/sda.
You attach /dev/blah as disk to your domain. Libvirt correctly
creates the /dev/blah -> /dev/sda symlink in the qemu namespace.
However, then you detach the disk, change the symlink so that it
points to /dev/sdb and tries to attach the disk again. This time,
however, the attach fails (well, qemu attaches wrong disk)
because the code assumes that symlinks don't change. Well they
This is inspired by test fix written by Eduardo Habkost.
Signed-off-by: Michal Privoznik <mprivozn redhat com>
Reviewed-by: Andrea Bolognani <abologna redhat com>
(cherry picked from commit db98e7f67ea0d7699410f514f01947cef5128a6c)