[Libvirt-ci] Fixed: libvirt/libvirt#1517 (master - 9e66ecb)

[Travis CI]

Build Update for libvirt/libvirt
-------------------------------------

Build: #1517
Status: Fixed

Duration: 19 mins and 53 secs
Commit: 9e66ecb (master)
Author: Daniel P. Berrangé
Message: conf: don't use virDomainVirtType in struct field

Use of enum types for struct fields is generally avoided since it causes
warnings if the compiler assumes the enum is unsigned. For example

  commit 8e2982b5767a25e5da6533c65bfdc648c95b3c69
  Author: Cole Robinson <crobinso at redhat.com>
  Date:   Tue Jul 24 16:27:54 2018 -0400

    conf: Clean up virDomainDefParseCaps

Introduced a line:

  if ((def->virtType = virDomainVirtTypeFromString(virttype)) < 0) {

which causes a build failure with CLang

  conf/domain_conf.c:19143:65: error: comparison of unsigned enum expression < 0 is always false [-Werror,-Wtautological-compare]

as the compiler is free to optimize away the "< 0" check due to the
assumption that the enum type is unsigned and always in range.

Signed-off-by: Daniel P. Berrangé <berrange at redhat.com>

View the changeset: https://github.com/libvirt/libvirt/compare/8c496a1d002b...9e66ecb5ea37

View the full build log and details: https://travis-ci.org/libvirt/libvirt/builds/408552209?utm_source=email&utm_medium=notification

--

You can configure recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications







This email was sent to libvirt-ci at redhat.com (mailto:libvirt-ci at redhat.com)
unsubscribe from this list (http://clicks.travis-ci.com/track/unsub.php?u=14313403&id=798ad55634504da49f40eb9a2da58168.q3yTAF39gfjNcLjHva7iXjXSQZI%3D&r=https%3A%2F%2Fmandrillapp.com%2Funsub%3Fmd_email%3Dlibvirt-ci%2540redhat.com)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/libvirt-ci/attachments/20180726/fc390b16/attachment.htm>