[Libvirt-ci] Still Failing: libvirt/libvirt#2801 (master - 47a7b8a)

[Travis CI]

Build Update for libvirt/libvirt
-------------------------------------

Build: #2801
Status: Still Failing

Duration: 31 mins and 59 secs
Commit: 47a7b8a (master)
Author: Laine Stump
Message: qemu: avoid double reservation of PCI address for interface type='hostdev'

Commit 01ca4010d86 (libvirt v5.1.0) moved address reservation for
hotplugged interface devices up to an earlier point in
qemuDomainAttachNetDevice(), because that function calls
qemuDomainSupportsNicdev() (in the case of
VIR_DOMAIN_NET_TYPE_VHOSTUSER), and qemuDomainSupportsNicdev() needs
to know the address type (for ARM machinetypes) and returns incorrect
results when the address type is "none".

This bugfix unfortunately caused a regression, because it also made PCI
address reservation happen before we noticed that the device was a
*hostdev* interface. Those interfaces are hotplugged by just calling
out to qemuDomainAttachHostdevDevice() - that function would then also
attempt to reserve the *same PCI address* that had just been reserved
in qemuDomainAttachNetDevice().

The solution is to move the bit of code that short-circuits out to
virDomainHostdevAttach() up *even earlier* so that no PCI address has
been allocated by the time it's called.

https://bugzilla.redhat.com/show_bug.cgi?id=1744523
Signed-off-by: Laine Stump <laine at redhat.com>
Reviewed-by: Andrea Bolognani <abologna at redhat.com>

View the changeset: https://github.com/libvirt/libvirt/compare/cf915455e440...47a7b8a96b63

View the full build log and details: https://travis-ci.org/libvirt/libvirt/builds/608827983?utm_medium=notification&utm_source=email

--

You can unsubscribe from build emails from the libvirt/libvirt repository going to https://travis-ci.org/account/preferences/unsubscribe?repository=4872032&utm_medium=notification&utm_source=email.
Or unsubscribe from *all* email updating your settings at https://travis-ci.org/account/preferences/unsubscribe?utm_medium=notification&utm_source=email.
Or configure specific recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/libvirt-ci/attachments/20191107/7ecd9761/attachment.htm>